Skip to content

fix: Handle custom style URLs for external viewers#773

Merged
spring-raining merged 2 commits intovivliostyle:mainfrom
yminod:fix-issue-755
Apr 4, 2026
Merged

fix: Handle custom style URLs for external viewers#773
spring-raining merged 2 commits intovivliostyle:mainfrom
yminod:fix-issue-755

Conversation

@yminod
Copy link
Copy Markdown
Contributor

@yminod yminod commented Mar 31, 2026

Fixes #755 by applying the approach mentioned in vivliostyle/vivliostyle.js#1522 (comment).

This updates custom style URLs for external viewers so that local --style / --user-style paths are resolved against the local CLI server, and adds a regression test.

@yminod yminod requested a review from spring-raining as a code owner March 31, 2026 06:30
Copy link
Copy Markdown
Member

@spring-raining spring-raining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction. Looks good!

@spring-raining spring-raining merged commit e74d722 into vivliostyle:main Apr 4, 2026
1 check passed
@github-actions github-actions Bot mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI option --style does not serve CSS when --viewer is specified

2 participants